Skip to content

chore: update @tanstack/config#5451

Closed
benmccann wants to merge 1 commit intoTanStack:mainfrom
benmccann:config-upgrade
Closed

chore: update @tanstack/config#5451
benmccann wants to merge 1 commit intoTanStack:mainfrom
benmccann:config-upgrade

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Oct 12, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies to align with the latest stable ecosystem; no runtime behavior changes.
  • Chores / Public API
    • Extended the server-side rendering public API with a new signal to mark render completion for integrators. No other runtime or UX changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2025 •
edited
Loading

Walkthrough

Added a devDependency version bump and extended the ServerSsr public interface with a new method setRenderFinished(): void. No other behavioral changes reported.

Changes

Cohort / File(s) Summary
Dependency management
package.json		 Bumped devDependency @tanstack/config from ^0.16.1 to ^0.21.0.
Router public API
packages/router-core/src/router.ts		 Added new method setRenderFinished: () => void to the exported ServerSsr interface (public API surface expanded).

Sequence Diagram(s)

sequenceDiagram
    participant Renderer as renderRouterToString
    participant ServerSsr as ServerSsr implementation

    Renderer->>ServerSsr: initial render call
    alt after initial render
        Renderer->>ServerSsr: setRenderFinished()
        Note right of ServerSsr #D3F6E3: marks render-as-finished\n(new API call)
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I twitch my nose and give a nod,
A tiny method springs from sod.
A config bump, a gentle cheer,
The render’s finished — hop, I'm here. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title correctly identifies the dependency update to @tanstack/config, which is a genuine part of this changeset, and thus meets the criteria for a partially related title even though it does not mention the added SSR interface method.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1fa60f and e9639d3.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • packages/router-core/src/router.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript in strict mode with extensive type safety across the codebase

Files:

  • packages/router-core/src/router.ts
packages/router-core/**

📄 CodeRabbit inference engine (AGENTS.md)

Keep framework-agnostic core router logic in packages/router-core/

Files:

  • packages/router-core/src/router.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test
🔇 Additional comments (1)
packages/router-core/src/router.ts (1)

756-756: Implementations Verified
setRenderFinished() is implemented in ssr-server.ts alongside onRenderFinished, satisfying the interface change—no further action required.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit e9639d3

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 2m 1s View ↗
nx run-many --target=build --exclude=examples/*... ❌ Failed 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-13 18:49:42 UTC

@benmccann benmccann closed this Oct 12, 2025
@benmccann benmccann reopened this Oct 13, 2025
@benmccann benmccann closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: router-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benmccann